search

WordPress / props-bot-action

A GitHub Action for compiling a list of contributor props.
Other
13 stars 5 forks source link

Fix typo in `issue_comment` event filter. #139

Closed desrosj closed 2 months ago

desrosj commented 2 months ago

What?

This fixes a typo in the types keyword to ensure the bot only runs for the specified event types.

Why?

By default, issue_comment runs when a comment is created, edited, and deleted. Because types was misspelled, the bot would run unnecessarily on comment edit or delete.

Props to @jeherve for reporting, and @aaronjorbin/@Mamaduka for reviewing and merging the original report in WordPress/Gutenberg#64557.

github-actions[bot] commented 2 months ago

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

Core Committers: Use this line as a base for the props when committing in SVN:

Props desrosj, mamaduka.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.