search

WordPress / props-bot-action

A GitHub Action for compiling a list of contributor props.
Other
13 stars 5 forks source link

Ensure text that is copied using the copy button isn’t encoded #31

Open aaronjorbin opened 9 months ago

aaronjorbin commented 9 months ago

when I used the copy button on iOS and pasted into the commit, it encoded the text

IMG_1269

This meant that @desrosj didnt get credit for https://github.com/WordPress/grunt-patch-wordpress/commit/59c8032f472d404ebde82d4eb79eacdf93bc98fd

aaronjorbin commented 9 months ago

I think this might be either iOS specific since I'm not seeing it on chrome on mac

desrosj commented 9 months ago

I think this might be either iOS specific since I'm not seeing it on chrome on mac

Which browser did you see this in while using iOS?

I also did not experience this on Firefox for Mac on my desktop. I don't think this a blocker for releasing a v1, but I think it's worth calling out in the release announcement. I'd argue that while it's convenient (and I do it too), maintainers probably should not be merging on mobile. Especially now that they'll need to manually review the list for accuracy.