search

WordPress / props-bot-action

A GitHub Action for compiling a list of contributor props.
Other
11 stars 3 forks source link

Tell Core Committers to include the list and not assume it's complete. #45

Closed costdev closed 7 months ago

costdev commented 7 months ago

What?

Tell Core Committers to make sure the usernames are included in the props list, to avoid missing props for Trac contributions if the committer assumes its GitHub/Trac-complete.

Why?

Props Bot currently handles interactions with a PR/related issues. Since it doesn't include Trac contributions yet, the props list it provides is likely incomplete.

github-actions[bot] commented 7 months ago

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

Core Committers: Use this line as a base for the props when committing in SVN:

Props costdev, desrosj, jorbin.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: costdev <costdev@git.wordpress.org>
Co-authored-by: desrosj <desrosj@git.wordpress.org>
Co-authored-by: aaronjorbin <jorbin@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

desrosj commented 7 months ago

I also realized while reviewing that there's a : in the Props line. That should not be there.