search

WordPress / props-bot-action

A GitHub Action for compiling a list of contributor props.
Other
13 stars 5 forks source link

Coding Standards: Use WordPress packages for coding standards - Step 1 #62

Closed aaronjorbin closed 9 months ago

aaronjorbin commented 9 months ago

First pass at improving the formating and linting. Before a big fix, I wanted to get this agreed on and likely also get a few other PRs merged.

What?

The coding standards should be the same as elsewhere in the WordPress project.

Why?

Consistent styles make it easier for people to contribute.

Testing Instructions

Does it work?

github-actions[bot] commented 9 months ago

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

Core Committers: Use this line as a base for the props when committing in SVN:

Props jorbin, desrosj.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: aaronjorbin <jorbin@git.wordpress.org>
Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

aaronjorbin commented 9 months ago

I'm planning to do this is three main chunks:

  1. Setup and agree on the configuration. (We are here now)
  2. Fix the formatting (Ideally as many PRs as possible are closed first so there is less conflict)
  3. Make sure linting is automated so it is enforced.
desrosj commented 9 months ago

Your plan sounds great to me. I think after #64 is merged we can proceed with steps 2 and 3. The other PRs remaining are experimental attempts at fixing an issue.