Tolerate selecting MySQL system variables

WordPress / sqlite-database-integration

Feature Plugin to add SQLite support to WordPress. Under Development.

GNU General Public License v2.0

202 stars 30 forks source link

Tolerate selecting MySQL system variables #109

Closed brandonpayton closed 2 months ago

brandonpayton commented 2 months ago

The purpose of this PR is to add more support for selecting MySQL system variables. Fixes #104.

Related to: https://github.com/WordPress/wordpress-playground/issues/1272 - "UpdraftPlus plugins doesn't fully work in Playground."

We'll start with failing tests for the set used by the UpdraftPlus plugin, but the ideal is to support as many MySQL variables as possible so there are no conflicts when using SQLite (and WordPress Playground).

brandonpayton commented 2 months ago

For a first pass, I am currently considering expanding this existing hack to replace queries for these variables with dummy SELECTs.

Doing this does appear to address the original error report here: https://github.com/WordPress/wordpress-playground/issues/1272

After that, in order to properly support these variables, we should review the list of all variables and decide which make sense to support and which make sense to replace with dummy GETs and SETs.

cc @adamziel