search

WordPress / sqlite-database-integration

Feature Plugin to add SQLite support to WordPress. Under Development.
GNU General Public License v2.0
233 stars 39 forks source link

Fatal errors with "show variables like X" queries #34

Open xavivars opened 1 year ago

xavivars commented 1 year ago

I'm testing the sqlite-database integration plugin on a production site, where I have (amongs other plugins) Wordfence installed.

While I managed to workaround a previous issue I submitted (see #32 ) by installing a more recent version of SQLite, today I found an issue that doesn't have such an easy workaround.

At some point, Wordfence executes SQL statements like show variables like 'max_allowed_packet' (see https://plugins.trac.wordpress.org/browser/wordfence/trunk/lib/wfDB.php#L146) and the SQLite database integration plugin throws a fatal error, as SQLite doesn't know how to handle such statement.

aristath commented 1 year ago

@xavivars Did you test with the stable version from w.org, or the trunk version from this repository? There have been lots of improvements on trunk which have not yet been released on w.org so maybe this has already been resolved? I need to do some more testing before releasing the update (mostly related to migrating from the performance-lab to the standalone plugin), but ideally we'd be able to solve this issue as well before releasing an update 👍

xavivars commented 1 year ago

I definitely used the one in the plugin repo, I thought it was in sync with GH.

I can take another look at it with the one from this repo