WordPress / theme-check

Theme Check plugin
https://wordpress.org/plugins/theme-check/
333 stars 107 forks source link

Improve child theme support #143

Open grappler opened 8 years ago

grappler commented 8 years ago

I have been looking at the code for textdomain to check that the textdomain matches the theme slug.

While doing so I realized that the theme check is checking the contents of the parent theme also when checking a child theme.

My proposal would be

Otto42 commented 8 years ago

Note that this is historically a problem. One we solved by doing the child-theme/parent-theme checks like this in the plugin, but then completely ignoring for the uploader.

The system on w.org does not actually have access to the parent when performing the check. So a child is more or less guaranteed to fail. Therefore all of theme-check is ignored when a child theme is uploaded. It still runs, it just doesn't care.

If you want to improve the plugin to work better for child themes, then by all means, go right ahead. It won't matter to w.org.

carolinan commented 4 years ago

See https://sv.wordpress.org/plugins/child-theme-check/ https://github.com/Zodiac1978/tl-template-checker