search

WordPress / theme-check

Theme Check plugin
https://wordpress.org/plugins/theme-check/
341 stars 114 forks source link

Screenshot dimensions #387

Closed kafleg closed 2 years ago

kafleg commented 3 years ago

Theme having invalid screenshot size doesn't restrict uploads or not showing any information in Theme Check Results: section in trac. Ticket, https://themes.trac.wordpress.org/ticket/104212

REQUIRED Screenshot dimensions are wrong! The ratio of width to height should be 4:3.

This is the message showing using the theme check plugin locally.

Also, there is information on the RECOMMENDED section, RECOMMENDED Screenshot size should be 1200x900, to account for HiDPI displays. Any 4:3 image size is acceptable, but 1200x900 is preferred.

TeBenachi commented 3 years ago

When a screenshot is larger than 1200x900, the theme check prompts two alerts. Consolidating into one alert may be less confusing to the authors.

Screen Shot 2021-08-18 at 4 58 46 AM
carolinan commented 3 years ago

Ratio and size are two different problems, not one.

kafleg commented 2 years ago

Related to this, https://github.com/WordPress/theme-check/pull/401

I am closing this issue.