WordPress / theme-experiments

Experimenting with themes made out of blocks.
GNU General Public License v2.0
549 stars 182 forks source link

Tag theme releases #195

Open ockham opened 3 years ago

ockham commented 3 years ago

Hey, would y'all be okay with tagging theme versions (i.e. using git tags)? E.g. assigning the tag tt1-blocks@0.4.3 to https://github.com/WordPress/theme-experiments/commit/f3d2c0dac4dd6a127b177178c5145c10f28401af.

This would make it simpler and more transparent to refer to this GH repo as a source from other places.

The concrete motivation for this is https://github.com/WordPress/gutenberg/issues/28692#issuecomment-772797992: It'd allow us to pin Gutenberg's (end-to-end test) dependency to

WordPress/theme-experiments/tt1-blocks#tt1-blocks@0.4.3

rather than

WordPress/theme-experiments/tt1-blocks#f3d2c0d
carolinan commented 3 years ago

I am not sure how to create (and tag) a release with only the theme - @aristath @kjellr do we create a new branch for only TT1 Blocks?

ockham commented 3 years ago

I am not sure how to create (and tag) a release with only the theme - @aristath @kjellr do we create a new branch for only TT1 Blocks?

I don't think there needs to be a separate branch, nor does the tag have to include one theme only! The tag would really just serve as a pointer that indicates the snapshot of the repo that reflects a given version of the theme -- it's perfectly fine to ignore what's going on with the other themes. (We do this in the Gutenberg repo -- if you look at the tags list there, there are e.g. tags for individual versions of each @wordpress/ package.)

carolinan commented 3 years ago

I am not sure if I did this correctly https://github.com/WordPress/theme-experiments/releases/tag/tt1-blocks%400.4.3

https://github.com/WordPress/theme-experiments/tags

kjellr commented 3 years ago

I think what you did there works Carolina — since this is a monorepo, I think we can just ignore the other themes when we package. Thanks for tagging this release!

ockham commented 3 years ago

Thanks a lot @carolinan, this looks perfect :+1: