WordPress / theme-experiments

Experimenting with themes made out of blocks.
GNU General Public License v2.0
546 stars 179 forks source link

TT1 blocks: empty space between between header and footer #222

Closed vindl closed 3 years ago

vindl commented 3 years ago

Currently we have margins around header and footer template parts in editing view of the Site Editor.

Screenshot 2021-02-23 at 14 36 16 Screenshot 2021-02-23 at 14 37 16

Would it make sense to remove them so as to align the header and footer with the beginning and ending of the page respectively?

cc @kjellr

carolinan commented 3 years ago

The theme does not add any extra top or bottom margins around template parts. Do you mean the editor style that Gutenberg adds?

.block-editor-block-list__block {
    margin-top: 28px;
    margin-bottom: 28px;
}

Then that is not a theme issue, but an editor issue?

vindl commented 3 years ago

Then that is not a theme issue, but an editor issue?

Yep, that seems to be the case then. I'll carry this over to editor repo and close this issue. Thanks!

creativecoder commented 3 years ago

This can be closed, replaced by https://github.com/WordPress/gutenberg/issues/29357