TT1 Blocks: Migrate Pullquote block styles

WordPress / theme-experiments

Experimenting with themes made out of blocks.

GNU General Public License v2.0

546 stars 179 forks source link

TT1 Blocks: Migrate Pullquote block styles #225

Closed danieldudzic closed 2 years ago

danieldudzic commented 3 years ago

Part of #82 Closes: #126

Dependencies:

Adding typography support for Pullquotes
Adding border-width support for Pullquotes (there's an Issue about adding support for the Table block: https://github.com/WordPress/gutenberg/issues/27651)
Adding padding support for Pullquotes (there are already conversations about adding support for other blocks: Code: https://github.com/WordPress/gutenberg/pull/27582 | Verse: https://github.com/WordPress/gutenberg/pull/27579)

PR: https://github.com/WordPress/gutenberg/pull/29361

kjellr commented 2 years ago

I refreshed this PR today. I removed the font size stuff since it still hasn't landed in Gutenberg, and was making the citation line really huge. Here's the current state:

TT1 Blocks	Twenty Twenty-One

As you can see, we're missing the ability to set the border to appear on just the top and bottom. I've opened a Gutenberg issue here to discuss that: https://github.com/WordPress/gutenberg/issues/34179

pbking commented 2 years ago

we're missing the ability to set the border to appear on just the top and bottom.

If we set the value of border.style to "solid none" that appropriately renders the borders like TwentyTwenyOne's:

And while the user wouldn't be able to reproduce the effect with the editor they can still switch away to any of the other options just fine.

I agree that the work in Gutenberg is still needed but I don't believe '"solid none"' is wrong. What do you think?

pbking commented 2 years ago

Add in a dash of typography styles and it's not a far throw from the original: