TT1 Blocks: The font size of the site title cannot be changed from the default.

WordPress / theme-experiments

Experimenting with themes made out of blocks.

GNU General Public License v2.0

549 stars 183 forks source link

TT1 Blocks: The font size of the site title cannot be changed from the default. #227

Closed miminari closed 3 years ago

miminari commented 3 years ago

I did some tests following this post. https://make.wordpress.org/test/2021/02/18/fse-program-testing-call-2-build-a-homepage-with-site-editing-blocks/

And I noticed the font size of the site title could not be changed from the default.

If you change the font size of your site from the settings, it will not change on the front view.

Editor View:

Front View:

This is probably because no style is given to .wp-block-site-title.has-extra-large-font-size, and similar class names.

Verification environment

TT1 Blocks Version: 0.4.4
Gutenberg 10.0.2
WordPress 5.6.2
Mac OS Big Sur 11.1
Chrome 88.0.4324.192

carolinan commented 3 years ago

Hi This is related to Gutenberg and not the theme itself, it will (hopefully) be fixed with https://github.com/WordPress/gutenberg/pull/29378

miminari commented 3 years ago

Thank you for reply. Does this mean that it's better not to have more styles in the block based theme than can be specified in theme.json?

aristath commented 3 years ago

Does this mean that it's better not to have more styles in the block based theme than can be specified in theme.json?

It depends on the styles. Basic and "universal" styles should be in the theme.json file, while more opinionated things that make a theme stand-out and add some character would still be in CSS files.

aristath commented 3 years ago

I'll go ahead and close this thread since it's not related to the TT1 theme and we already have the other ticket in Gutenberg 👍