search

WordPress / theme-experiments

Experimenting with themes made out of blocks.
GNU General Public License v2.0
546 stars 179 forks source link

Remove CSS from emptytheme? #231

Closed carolinan closed 3 years ago

carolinan commented 3 years ago

@kjellr Should we remove alignments-front.css from emptytheme so that it is easier to use this theme to compare the actual editor and front styles?

youknowriad commented 3 years ago

I think we should be able to do that after https://github.com/WordPress/gutenberg/pull/29335 lands. In fact that's exactly what I did to start working on the PR.

Removing it before the PR lands could also be an option but you might not get the alignments working properly in the frontend for posts.

pbking commented 3 years ago

I think seeing stock results trumps it working correctly. My 'druthers is to remove it sooner than later. I started using a different "empty theme" for that reason.

kjellr commented 3 years ago

I don't have a strong opinion, but I lean towards keeping it in there until https://github.com/WordPress/gutenberg/pull/29335 lands. Mostly because it's a lot easier for folks to to remove that CSS than it is to re-write it if they want their theme working today.

carolinan commented 3 years ago

This has been done, closing-