WordPress / theme-experiments

Experimenting with themes made out of blocks.
GNU General Public License v2.0
549 stars 183 forks source link

TT1 Blocks: Media and Text Block is stretched at the frontend #259

Closed evakaneva closed 2 years ago

evakaneva commented 3 years ago

I originally reported this in Gutenberg, but I noticed it doesn't happen with other themes. So it is a TT1 blocks specific issue.

Description

Images from the media and text block show as expected in the preview but are stretched on the frontend.

Step-by-step reproduction instructions

  1. Create a media and text block
  2. Add image and text
  3. Save/publish
  4. Open post on the frontend
  5. Observe it is stretched

Expected behaviour

I would expect that the frontend looks exactly like the preview.

Actual behaviour

At the frontend, images from the media and text block are stretched.

Screenshots or screen recording (optional)

stretchbugmediatextblock

Code snippet (optional)

WordPress information

Device information

carolinan commented 3 years ago

I can also reproduce this when using emptytheme so I am not sure if this is a theme or Gutenberg issue 🤔

The block editor uses this CSS, but Gutenberg does not included it on the front:

.block-editor__container img {
    max-width: 100%;
    height: auto;
}

In Armando, I have set

img {
    max-width: 100%;
    height: auto;
}

And this seems to fix it.

MaggieCabrera commented 3 years ago

There's a PR on GB for this, but it didn't seem to have much traction: https://github.com/WordPress/gutenberg/pull/30092

carolinan commented 3 years ago

I see discussions but no decision. Do we fix it in the theme meanwhile?

MaggieCabrera commented 3 years ago

I see discussions but no decision. Do we fix it in the theme meanwhile?

it's hard to say. I'm really against having to add those lines to every single theme to avoid the bug, but it doesn't look like that's going to make it to the editor any time soon. If we decide to add it, I'd add a comment linking the issue or the PR and go back and delete the line if the PR is ever merged.

MaggieCabrera commented 2 years ago

The GB PR was merged so I'm closing this