search

WordPress / theme-experiments

Experimenting with themes made out of blocks.
GNU General Public License v2.0
549 stars 183 forks source link

Feedback on trying to remove padding between template part and cover block #283

Closed annezazu closed 3 years ago

annezazu commented 3 years ago

This was found as part of the ninth call for testing for the FSE Outreach Program in this Tavern writeup:

A spacing issue is what led me to ditch TT1 Blocks and switch to a custom theme. The following screenshot is my final work with the former. You may notice the gaping green background between the nav menu group and the header image below it...No amount of tricks or rearrangement of blocks seemed to remove that space, and I simply could not live with that. I had already solved about 90% of Gutenberg’s spacing issues with my own theme and did not feel like writing any new CSS to address this. Making the switch also meant that I could get rid of several Spacer blocks I had in place.

fse-9-tt1-blocks

It's unclear to me if this is for sure a theme issue with TT1 or if this might be a Gutenberg problem. For now, here's a quick video showing the spacing issue:

https://user-images.githubusercontent.com/26996883/129277584-316fc266-08a4-4be2-9f7b-7a61adb137dc.mov

cc @carolinan might you be able to shed some light on this? Happy to properly report in Gutenberg if that's where this should go but wanted to share here since Justin mentioned he didn't have this issue with his custom block theme.

carolinan commented 3 years ago

My first suspicion would be the default bottom margin that is placed on columns blocks. Without seeing Justins theme, I can still say that this margin is something I remove from my custom theme.

annezazu commented 3 years ago

Ah ha. Thank you for clarifying. I'm going to close this out in that case. Feel free to re-open if it's something that feels worthwhile to address in TT1!