WordPress / theme-experiments

Experimenting with themes made out of blocks.
GNU General Public License v2.0
549 stars 183 forks source link

TT1 blocks: implement new comments block #305

Closed MaggieCabrera closed 2 years ago

MaggieCabrera commented 2 years ago

This PR implements the new comments block in TT1 blocks

Before:

Screenshot 2022-07-06 at 10 27 37

After:

Screenshot 2022-07-06 at 10 28 11

In other themes I've made this into a hidden pattern to avoid code repetition, I'm not sure if we should do the same for TT1b. I'm open to suggestions.

carolinan commented 2 years ago

All of this could be done in a follow up PR, or, if you want to continue working on it:


Comments area of twenty twenty-one: https://wp-themes.com/twentytwentyone/?p=1#comments

Tt1 blocks, before PR: https://wp-themes.com/tt1-blocks/?p=1#comments

MaggieCabrera commented 2 years ago

Yeah I can add those changes to this PR

MaggieCabrera commented 2 years ago

I think that's all the changes!

carolinan commented 2 years ago

Aside: Ha, WP does not understand what to do when there is both a block-templates and a templates folder