search

WordPress / theme-review-action

Other
30 stars 9 forks source link

Redundant test results. #27

Open StevenDufresne opened 3 years ago

StevenDufresne commented 3 years ago

Some UI tests loop through default pages and log the errors. It appears that more often than not if the issue persists on the home page, it will appear on the other pages. We should consider only running a subset of UI tests on all the pages to avoid extra noise or alternatively, find a better way to log the errors.

Example:

/ should not contain javascript errors. Found Error: TypeError: Cannot use 'in' operator to search for 'clientWidth' in null at js/prod/front-end.js?ver=1614246500:1:1442 at Array.forEach (<anonymous>) at Module.238 (js/prod/front-end.js?ver=1614246500:1:1367) at n (js/prod/front-end.js?ver=1614246500:1:110) at Object.76 (js/prod/front-end.js?ver=1614246500:1:13510) at n (js/prod/front-end.js?ver=1614246500:1:110) at js/prod/front-end.js?ver=1614246500:1:902 at js/prod/front-end.js?ver=1614246500:1:912
See: https://github.com/WordPress/theme-review-action/blob/trunk/docs/ui-errors.md#browser-console-should-not-contain-errors

/?cat=1 should not contain javascript errors. Found Error: TypeError: Cannot use 'in' operator to search for 'clientWidth' in null at js/prod/front-end.js?ver=1614246500:1:1442 at Array.forEach (<anonymous>) at Module.238 (js/prod/front-end.js?ver=1614246500:1:1367) at n (js/prod/front-end.js?ver=1614246500:1:110) at Object.76 (js/prod/front-end.js?ver=1614246500:1:13510) at n (js/prod/front-end.js?ver=1614246500:1:110) at js/prod/front-end.js?ver=1614246500:1:902 at js/prod/front-end.js?ver=1614246500:1:912
See: https://github.com/WordPress/theme-review-action/blob/trunk/docs/ui-errors.md#browser-console-should-not-contain-errors

/?tag=alignment-2 should not contain javascript errors. Found Error: TypeError: Cannot use 'in' operator to search for 'clientWidth' in null at js/prod/front-end.js?ver=1614246500:1:1442 at Array.forEach (<anonymous>) at Module.238 (js/prod/front-end.js?ver=1614246500:1:1367) at n (js/prod/front-end.js?ver=1614246500:1:110) at Object.76 (js/prod/front-end.js?ver=1614246500:1:13510) at n (js/prod/front-end.js?ver=1614246500:1:110) at js/prod/front-end.js?ver=1614246500:1:902 at js/prod/front-end.js?ver=1614246500:1:912
See: https://github.com/WordPress/theme-review-action/blob/trunk/docs/ui-errors.md#browser-console-should-not-contain-errors

/?post_format=gallery should not contain javascript errors. Found Error: TypeError: Cannot use 'in' operator to search for 'clientWidth' in null at js/prod/front-end.js?ver=1614246500:1:1442 at Array.forEach (<anonymous>) at Module.238 (js/prod/front-end.js?ver=1614246500:1:1367) at n (js/prod/front-end.js?ver=1614246500:1:110) at Object.76 (js/prod/front-end.js?ver=1614246500:1:13510) at n (js/prod/front-end.js?ver=1614246500:1:110) at js/prod/front-end.js?ver=1614246500:1:902 at js/prod/front-end.js?ver=1614246500:1:912
See: https://github.com/WordPress/theme-review-action/blob/trunk/docs/ui-errors.md#browser-console-should-not-contain-errors
carolinan commented 3 years ago

Repeated results are also shown for the link test.