WordPress / theme-review-action

Other
30 stars 9 forks source link

Question: How to handle checks that are in both Theme Check and theme review action? #33

Open carolinan opened 3 years ago

carolinan commented 3 years ago

Some checks are in both theme check and theme review action. Are there any benefits with this?

For example, checking if the theme folder includes a screenshot and required files.

StevenDufresne commented 3 years ago

It wasn't intended but since we need a theme to have the basics to start up the environment, or determine which theme type we are testing, we need to ensure a few things are in place. If we are able to run the theme-check without needing an environment (statically), which seems quite possible. We could remove it from the theme review action in the future.