Switch to using `run_themechecks_against_theme()` in Theme Check

[dd32]

As of the latest version of theme check, it'll fatal if you call run_themechecks() without passing the context parameters.

It's simpler to just switch to using run_themechecks_against_theme().

See https://meta.trac.wordpress.org/changeset/11035 for the Theme Directory alterations.

This is untested, using the GitHub editing UI, but I think it might/should work depending on where CheckTheme.php is mounted in the container.

[StevenDufresne]

Just ran this locally, agreed it fixes the fatal but...

[18-Jun-2021 00:08:28 UTC] PHP Warning:  file_get_contents(): Filename cannot be empty in /var/www/html/wp-content/plugins/theme-check/checkbase.php on line 64
Warning: file_get_contents(): Filename cannot be empty in /var/www/html/wp-content/plugins/theme-check/checkbase.php on line 64
[18-Jun-2021 00:08:28 UTC] PHP Notice:  Undefined variable: php in /var/www/html/wp-content/plugins/theme-check/checkbase.php on line 70
Notice: Undefined variable: php in /var/www/html/wp-content/plugins/theme-check/checkbase.php on line 70
[18-Jun-2021 00:08:28 UTC] PHP Notice:  Undefined variable: css in /var/www/html/wp-content/plugins/theme-check/checkbase.php on line 70
Notice: Undefined variable: css in /var/www/html/wp-content/plugins/theme-check/checkbase.php on line 70
[18-Jun-2021 00:08:28 UTC] PHP Warning:  Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-admin-menu-check.php on line 42
Warning: Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-admin-menu-check.php on line 42
[18-Jun-2021 00:08:28 UTC] PHP Warning:  Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-admin-menu-check.php on line 69
Warning: Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-admin-menu-check.php on line 69
[18-Jun-2021 00:08:28 UTC] PHP Warning:  Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-bad-things-check.php on line 50
Warning: Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-bad-things-check.php on line 50
[18-Jun-2021 00:08:28 UTC] PHP Warning:  implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-basic-check.php on line 28
Warning: implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-basic-check.php on line 28
[18-Jun-2021 00:08:28 UTC] PHP Warning:  implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-block-patterns-check.php on line 31
Warning: implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-block-patterns-check.php on line 31
[18-Jun-2021 00:08:28 UTC] PHP Warning:  implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-cdn-check.php on line 31
Warning: implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-cdn-check.php on line 31
[18-Jun-2021 00:08:28 UTC] PHP Warning:  implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-cdn-check.php on line 32
Warning: implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-cdn-check.php on line 32
[18-Jun-2021 00:08:28 UTC] PHP Warning:  implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-comment-pagination-check.php on line 31
Warning: implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-comment-pagination-check.php on line 31
[18-Jun-2021 00:08:28 UTC] PHP Warning:  implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-comment-reply-check.php on line 30
Warning: implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-comment-reply-check.php on line 30
[18-Jun-2021 00:08:28 UTC] PHP Warning:  implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-comments-check.php on line 30
Warning: implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-comments-check.php on line 30
[18-Jun-2021 00:08:28 UTC] PHP Warning:  Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-constants-check.php on line 48
Warning: Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-constants-check.php on line 48
[18-Jun-2021 00:08:28 UTC] PHP Warning:  Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-customizer-check.php on line 34
Warning: Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-customizer-check.php on line 34
[18-Jun-2021 00:08:28 UTC] PHP Warning:  Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-deprecated-check.php on line 1149
Warning: Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-deprecated-check.php on line 1149
[18-Jun-2021 00:08:28 UTC] PHP Warning:  Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-deprecated-param-check.php on line 55
Warning: Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-deprecated-param-check.php on line 55
[18-Jun-2021 00:08:28 UTC] PHP Warning:  Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-deregister-check.php on line 20
Warning: Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-deregister-check.php on line 20
[18-Jun-2021 00:08:28 UTC] PHP Warning:  array_keys() expects parameter 1 to be array, null given in /var/www/html/wp-content/plugins/theme-check/checks/class-directories-check.php on line 40
Warning: array_keys() expects parameter 1 to be array, null given in /var/www/html/wp-content/plugins/theme-check/checks/class-directories-check.php on line 40
[18-Jun-2021 00:08:28 UTC] PHP Warning:  array_keys() expects parameter 1 to be array, null given in /var/www/html/wp-content/plugins/theme-check/checks/class-directories-check.php on line 41
Warning: array_keys() expects parameter 1 to be array, null given in /var/www/html/wp-content/plugins/theme-check/checks/class-directories-check.php on line 41
[18-Jun-2021 00:08:28 UTC] PHP Warning:  array_merge(): Expected parameter 1 to be an array, null given in /var/www/html/wp-content/plugins/theme-check/checks/class-directories-check.php on line 42
Warning: array_merge(): Expected parameter 1 to be an array, null given in /var/www/html/wp-content/plugins/theme-check/checks/class-directories-check.php on line 42
[18-Jun-2021 00:08:28 UTC] PHP Warning:  Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-directories-check.php on line 45
Warning: Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-directories-check.php on line 45
[18-Jun-2021 00:08:28 UTC] PHP Warning:  implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-editor-style-check.php on line 32
Warning: implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-editor-style-check.php on line 32
[18-Jun-2021 00:08:28 UTC] PHP Warning:  Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-escaping-check.php on line 46
Warning: Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-escaping-check.php on line 46
[18-Jun-2021 00:08:28 UTC] PHP Warning:  Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-favicon-check.php on line 34
Warning: Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-favicon-check.php on line 34
[18-Jun-2021 00:08:28 UTC] PHP Warning:  Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-file-check.php on line 32
Warning: Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-file-check.php on line 32
[18-Jun-2021 00:08:28 UTC] PHP Warning:  Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-file-check.php on line 38
Warning: Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-file-check.php on line 38
[18-Jun-2021 00:08:28 UTC] PHP Warning:  Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-filesystem-http-check.php on line 41
Warning: Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-filesystem-http-check.php on line 41
[18-Jun-2021 00:08:28 UTC] PHP Warning:  implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-generated-check.php on line 29
Warning: implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-generated-check.php on line 29
[18-Jun-2021 00:08:28 UTC] PHP Warning:  implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-gravatar-check.php on line 28
Warning: implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-gravatar-check.php on line 28
[18-Jun-2021 00:08:28 UTC] PHP Warning:  Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-i18n-check.php on line 36
Warning: Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-i18n-check.php on line 36
[18-Jun-2021 00:08:28 UTC] PHP Warning:  Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-iframe-check.php on line 35
Warning: Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-iframe-check.php on line 35
[18-Jun-2021 00:08:28 UTC] PHP Warning:  Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-include-check.php on line 33
Warning: Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-include-check.php on line 33
[18-Jun-2021 00:08:28 UTC] PHP Warning:  Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-line-endings-check.php on line 28
Warning: Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-line-endings-check.php on line 28
[18-Jun-2021 00:08:28 UTC] PHP Warning:  Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-line-endings-check.php on line 44
Warning: Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-line-endings-check.php on line 44
[18-Jun-2021 00:08:28 UTC] PHP Warning:  Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-link-check.php on line 43
Warning: Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-link-check.php on line 43
[18-Jun-2021 00:08:28 UTC] PHP Warning:  implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-nav-menu-check.php on line 31
Warning: implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-nav-menu-check.php on line 31
[18-Jun-2021 00:08:28 UTC] PHP Warning:  Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-nav-menu-check.php on line 58
Warning: Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-nav-menu-check.php on line 58
[18-Jun-2021 00:08:28 UTC] PHP Warning:  Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-no-hidden-admin-bar-check.php on line 33
Warning: Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-no-hidden-admin-bar-check.php on line 33
[18-Jun-2021 00:08:28 UTC] PHP Warning:  Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-no-hidden-admin-bar-check.php on line 51
Warning: Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-no-hidden-admin-bar-check.php on line 51
[18-Jun-2021 00:08:28 UTC] PHP Warning:  Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-non-printable-check.php on line 28
Warning: Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-non-printable-check.php on line 28
[18-Jun-2021 00:08:28 UTC] PHP Warning:  Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-php-short-tags-check.php on line 28
Warning: Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-php-short-tags-check.php on line 28
[18-Jun-2021 00:08:28 UTC] PHP Warning:  implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-plugin-territory-check.php on line 30
Warning: implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-plugin-territory-check.php on line 30
[18-Jun-2021 00:08:28 UTC] PHP Warning:  implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-post-format-check.php on line 28
Warning: implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-post-format-check.php on line 28
[18-Jun-2021 00:08:28 UTC] PHP Warning:  implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-post-format-check.php on line 29
Warning: implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-post-format-check.php on line 29
[18-Jun-2021 00:08:28 UTC] PHP Warning:  Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-post-format-check.php on line 37
Warning: Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-post-format-check.php on line 37
[18-Jun-2021 00:08:28 UTC] PHP Warning:  implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-post-pagination-check.php on line 29
Warning: implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-post-pagination-check.php on line 29
[18-Jun-2021 00:08:28 UTC] PHP Warning:  implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-post-thumbnail-check.php on line 31
Warning: implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-post-thumbnail-check.php on line 31
[18-Jun-2021 00:08:28 UTC] PHP Warning:  implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-screen-reader-text-check.php on line 28
Warning: implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-screen-reader-text-check.php on line 28
[18-Jun-2021 00:08:28 UTC] PHP Warning:  Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-script-tag-check.php on line 28
Warning: Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-script-tag-check.php on line 28
[18-Jun-2021 00:08:28 UTC] PHP Warning:  Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-search-form-check.php on line 31
Warning: Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-search-form-check.php on line 31
[18-Jun-2021 00:08:28 UTC] PHP Warning:  Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-site-url-check.php on line 31
Warning: Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-site-url-check.php on line 31
[18-Jun-2021 00:08:28 UTC] PHP Warning:  implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-style-css-header-check.php on line 28
Warning: implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-style-css-header-check.php on line 28
[18-Jun-2021 00:08:28 UTC] PHP Warning:  implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-suggested-styles-check.php on line 29
Warning: implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-suggested-styles-check.php on line 29
[18-Jun-2021 00:08:28 UTC] PHP Warning:  implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-tag-check.php on line 17
Warning: implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-tag-check.php on line 17
[18-Jun-2021 00:08:28 UTC] PHP Warning:  implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-theme-support-check.php on line 28
Warning: implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-theme-support-check.php on line 28
[18-Jun-2021 00:08:28 UTC] PHP Warning:  implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-theme-support-title-tag.php on line 28
Warning: implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-theme-support-title-tag.php on line 28
[18-Jun-2021 00:08:28 UTC] PHP Warning:  Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-time-date-check.php on line 34
Warning: Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-time-date-check.php on line 34
[18-Jun-2021 00:08:28 UTC] PHP Warning:  implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-title-check.php on line 32
Warning: implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-title-check.php on line 32
[18-Jun-2021 00:08:28 UTC] PHP Warning:  Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-title-check.php on line 34
Warning: Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-title-check.php on line 34
[18-Jun-2021 00:08:28 UTC] PHP Warning:  Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-underscores-check.php on line 85
Warning: Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-underscores-check.php on line 85
[18-Jun-2021 00:08:28 UTC] PHP Warning:  implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-widgets-check.php on line 31
Warning: implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/class-widgets-check.php on line 31
[18-Jun-2021 00:08:28 UTC] PHP Warning:  array_merge(): Expected parameter 1 to be an array, null given in /var/www/html/wp-content/plugins/theme-check/checks/class-worms-check.php on line 21
Warning: array_merge(): Expected parameter 1 to be an array, null given in /var/www/html/wp-content/plugins/theme-check/checks/class-worms-check.php on line 21
[18-Jun-2021 00:08:28 UTC] PHP Warning:  Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-worms-check.php on line 30
Warning: Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/class-worms-check.php on line 30
[18-Jun-2021 00:08:28 UTC] PHP Warning:  implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/content-width.php on line 9
Warning: implode(): Invalid arguments passed in /var/www/html/wp-content/plugins/theme-check/checks/content-width.php on line 9
[18-Jun-2021 00:08:28 UTC] PHP Warning:  Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/textdomain.php on line 62
Warning: Invalid argument supplied for foreach() in /var/www/html/wp-content/plugins/theme-check/checks/textdomain.php on line 62

Do you think any of those matter?

[dd32]

Do you think any of those matter?

Most definitely :) I hadn't actually run this yet.

The PHP Notices will be fixed by https://github.com/WordPress/theme-check/commit/bba5fefad5ae10f1cf50070e9260230770039d9f

The rest of it is legit though.

I've run into several issues though:

• Half the time I can't run it locally, as it failed to compile xDebug or libsass which left wp-env in a bad state. It looks like wp-env might be building the wordpress image rather than fetching it.. that might explain some of the long load time..
• Half the time it runs fine
• I can't even figure out how this file is used.

[psrpinto]

I just tested this locally and it fixes the fatal errors I was having:

[04-Aug-2021 13:37:13 UTC] PHP Fatal error:  Uncaught Error: Call to a member function get() on null in /var/www/html/wp-content/plugins/theme-check/checks/class-underscores-check.php:46
Stack trace:
#0 /var/www/html/wp-content/plugins/theme-check/checkbase.php(103): Underscores_Check->check(Array, Array, Array)
#1 phar:///usr/local/bin/wp/vendor/wp-cli/eval-command/src/EvalFile_Command.php(71) : eval()'d code(27): run_themechecks(Array, Array, Array)
#2 phar:///usr/local/bin/wp/vendor/wp-cli/eval-command/src/EvalFile_Command.php(71) : eval()'d code(171): WPORG_CheckTheme->check_theme(Array)
#3 phar:///usr/local/bin/wp/vendor/wp-cli/eval-command/src/EvalFile_Command.php(71) : eval()'d code(181): WPORG_CheckTheme->run_check()
#4 phar:///usr/local/bin/wp/vendor/wp-cli/eval-command/src/EvalFile_Command.php(71): eval()
#5 phar:///usr/local/bin/wp/vendor/wp-cli/eval-command/src/EvalFile_Command.php(48): EvalFile_Command::execute_eval('./actions/theme...', Array)
#6 [internal function]: EvalFile_Command->__invoke(Array, Array)
#7 phar:///usr/local/bin/wp/vend in /var/www/html/wp-content/plugins/theme-check/checks/class-underscores-check.php on line 46

Any chance we could get this merged?