Closed dd32 closed 2 years ago
For example, take this theme run: https://themes.trac.wordpress.org/ticket/106344#comment:6
The fatal error occured within a HTML attribute (See echo esc_attr_() within https://themes.trac.wordpress.org/changeset/155597) and so wasn't matched by the fatal extraction from the DOM.
echo esc_attr_()
I guess this means that more might need to be done to either close the attribute before outputting errors or doing some kind of string parsing on the DOM rather than simply relying upon the DOM
Agreed. The regular expression isn't very flexible at the moment:
https://github.com/WordPress/theme-review-action/blob/64554690d3e355c34530111cdeaa1d766b8cae11/actions/ui-check/tests/utils/helpers.js#L7
For example, take this theme run: https://themes.trac.wordpress.org/ticket/106344#comment:6
The fatal error occured within a HTML attribute (See
echo esc_attr_()
within https://themes.trac.wordpress.org/changeset/155597) and so wasn't matched by the fatal extraction from the DOM.I guess this means that more might need to be done to either close the attribute before outputting errors or doing some kind of string parsing on the DOM rather than simply relying upon the DOM