search

WordPress / twentyseventeen

Twenty Seventeen is a theme now included in all WordPress installs. To report any issues please go here: https://core.trac.wordpress.org/newticket
180 stars 126 forks source link

Remove letter-spacing for all non-latin alphabets #460

Closed melchoyce closed 8 years ago

melchoyce commented 8 years ago

Fixes #365.

laurelfulford commented 8 years ago

@melchoyce If we're doing a sweeping !important letter-spacing for all the languages we've included styles for, we probably don't need them on a language by language basis on the headers, too. What do you think about removing those?

laurelfulford commented 8 years ago

And we should get the editor-style.css to match whatever's changed here, too - thanks!

josephfusco commented 8 years ago

Also we should also be able to use letter-spacing: 0 instead of letter-spacing: normal. I don't see anything specifically on it in the WP CSS Coding Standards? @ntwb

melchoyce commented 8 years ago

If we're doing a sweeping !important letter-spacing for all the languages we've included styles for, we probably don't need them on a language by language basis on the headers, too. What do you think about removing those?

Makes sense! Done :)

Also we should also be able to use letter-spacing: 0 instead of letter-spacing: normal. I don't see anything specifically on it in the WP CSS Coding Standards?

Also done :)

melchoyce commented 8 years ago

And we should get the editor-style.css to match whatever's changed here, too - thanks!

@laurelfulford I'll do a second PR for that 👍

melchoyce commented 8 years ago

Couldn't get the conflicts to happen locally, so I opened a new PR: #473

joyously commented 8 years ago

Um, here is the definition of letter-spacing:normal

The spacing is the normal spacing for the current font. Unlike a value of 0, this value allows the user agent to alter the space between characters in order to justify text.