WordPress / twentyseventeen

Twenty Seventeen is a theme now included in all WordPress installs. To report any issues please go here: https://core.trac.wordpress.org/newticket
180 stars 125 forks source link

Add support for Urdu #476

Closed grappler closed 7 years ago

grappler commented 7 years ago

Adds support for Urdu

@ahmadawais Could you double check that this is right?

ahmadawais commented 7 years ago

@grappler I seldom work on translation these days, while lang=ur is def the right, I am not sure how Tahoma font will render Urdu. Noto on the other hand would be a better choice.

grappler commented 7 years ago

@ahmadawais This is how it looks in a Arabic https://github.com/WordPress/twentyseventeen/pull/398 The problem with Noto we would need to load it from Google Fonts.

ahmadawais commented 7 years ago

Sure go ahead then. :)

melchoyce commented 7 years ago

Thanks @grappler!

I don't see Urdu in the Site Language list:

screen shot 2016-10-18 at 9 17 31 pm screen shot 2016-10-18 at 9 18 01 pm

Is there anything special I need to do to find it?

grappler commented 7 years ago

Urdu is at 95% so that is why it is not showing up. https://translate.wordpress.org/locale/ur/default/wp/dev

melchoyce commented 7 years ago

Thanks 👍