search

WordPress / twentyseventeen

Twenty Seventeen is a theme now included in all WordPress installs. To report any issues please go here: https://core.trac.wordpress.org/newticket
180 stars 125 forks source link

Social menu SVG icons on Safari 10 #485

Closed afercia closed 7 years ago

afercia commented 7 years ago

Not sure if it's just me but quickly checking the social menu svg icons, here's how they appear for me on Safari 10:

screen shot 2016-10-19 at 08 57 42

On Chrome they look OK:

screen shot 2016-10-19 at 08 57 32

afercia commented 7 years ago

Also, the focus style on the social menu icons is based on color only. Would need an additional indicator since color only is not enough for accessibility.

samikeijonen commented 7 years ago

I see the similar "flash" in Chrome on Windows but then back to normal. I don't see it on my own theme so I suspect it's CSS related.

Also, the focus style on the social menu icons is based on color only. Would need an additional indicator since color only is not enough for accessibility.

I'd add outline (thin dotted for example) for social links also.

davidakennedy commented 7 years ago

@afercia Did you have JavaScript off?

We run a test for SVGs in JS – and if it fails, we show the screen reader text fallback there and hide the SVG... Looks like something choked.

I can't reproduce this in Safari 10.

afercia commented 7 years ago

Did you have JavaScript off? Ugh, my bad. Sorry 😁