WordPress / twentyseventeen

Twenty Seventeen is a theme now included in all WordPress installs. To report any issues please go here: https://core.trac.wordpress.org/newticket
180 stars 125 forks source link

Keyboard navigation on Safari 10 #486

Closed afercia closed 7 years ago

afercia commented 7 years ago

Not sure if it's just me but keyboard navigation on Safari 10 has some weird behaviour:

samikeijonen commented 7 years ago

at some point while tabbing the tab order starts again from the root and it's impossible for me to even reach the sidebar

Is that point always the same point or random one?

afercia commented 7 years ago

Seems there are multiple points here this happen. A first one is the menu drop-down, when a navigation menu has sub-items. A second one, after tabbing on a post published date and author name (before the post title).

davidakennedy commented 7 years ago

Thanks @afercia! I can reproduce and this is really weird. I don't see it happening in Chrome or Firefox. I also don't see any JS errors in the console.

I'll dig in and see what's going on.

afercia commented 7 years ago

@davidakennedy I'm afraid it's because the SVGs, highly suspect the use xlink thing. Disabled JS, disabled CSS, and it still happens when tabbing on focusable elements close to each SVG:

screen shot 2016-10-19 at 17 14 17

To quickly double check, just made twentyseventeen_get_svg() return an empty string and the bugs disappears.

afercia commented 7 years ago

Seems we're not alone... https://github.com/facebook/react/issues/7852

samikeijonen commented 7 years ago

That's a weird bug in Safari. Hope it will be fixed very soon.

karmatosed commented 7 years ago

Reported in trac: https://core.trac.wordpress.org/ticket/38387