search

WordPress / twentyseventeen

Twenty Seventeen is a theme now included in all WordPress installs. To report any issues please go here: https://core.trac.wordpress.org/newticket
180 stars 126 forks source link

Adds preconnect to Google Fonts. #491

Closed davidakennedy closed 8 years ago

davidakennedy commented 8 years ago

Fixes #105.

davidakennedy commented 8 years ago

Credit should go to leobaiano for this one. See #106.

swissspidy commented 8 years ago

The PR looks good so far. According to the discussion at #37171 an array would need to passed though to add the crossorigin attribute. Example:

$urls[] = array(
    'href' => 'https://fonts.gstatic.com',
    'crossorigin',
);

This causes some notices on pre-4.7 installs, however, since this is a new feature. See https://core.trac.wordpress.org/changeset/38826.

leobaiano commented 8 years ago

Tks.