search

WordPress / twentyseventeen

Twenty Seventeen is a theme now included in all WordPress installs. To report any issues please go here: https://core.trac.wordpress.org/newticket
180 stars 125 forks source link

Remove Genericons #492

Closed melchoyce closed 7 years ago

melchoyce commented 7 years ago

Since we’re using Font Awesome now instead.

samikeijonen commented 7 years ago

Note that we still have couple of icons from Genericons family. I would not remove that Copyright info from Readme file.

melchoyce commented 7 years ago

Which icons? We should remove them.

samikeijonen commented 7 years ago

I don't think we should remove them because they are used in a theme.

Atleast dropdown icon and arrows are from Genericon.

Why? Because there is no same kind of icons in font awesome that would fit in the design.

I'm pretty sure I asked about it in early tickets:)

On Oct 19, 2016 23:27, "Mel Choyce" notifications@github.com wrote:

Which icons? We should remove them.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/WordPress/twentyseventeen/pull/492#issuecomment-254930558, or mute the thread https://github.com/notifications/unsubscribe-auth/ABvG_8ZpyMDLm3qoZ_Gjo673xSnsyz7Lks5q1n0cgaJpZM4KbHXN .