search

WordPress / twentyseventeen

Twenty Seventeen is a theme now included in all WordPress installs. To report any issues please go here: https://core.trac.wordpress.org/newticket
180 stars 125 forks source link

Incorrect use of `_x()` in `twentyseventeen_posted_on()` #495

Closed ocean90 closed 7 years ago

ocean90 commented 7 years ago

https://github.com/WordPress/twentyseventeen/blob/5b5e4e86c2b8343863d7633758987da93c2bf2e8/inc/template-tags.php#L20

_x() is used to differ two similar strings with different meanings. Translators comments are used to describe placeholders.

ocean90 commented 7 years ago

Same for twentyseventeen_time_link(), see https://github.com/WordPress/twentyseventeen/blob/a15f8d1ed4003007b8e25330dc787cda7b7a32f7/inc/template-tags.php#L48.

karmatosed commented 7 years ago

Moved to trac: https://core.trac.wordpress.org/ticket/38383