navigation.js should be enqueued with jQuery as dependency

WordPress / twentyseventeen

Twenty Seventeen is a theme now included in all WordPress installs. To report any issues please go here: https://core.trac.wordpress.org/newticket

180 stars 125 forks source link

navigation.js should be enqueued with jQuery as dependency #504

Closed ghost closed 7 years ago

ghost commented 7 years ago

https://core.trac.wordpress.org/changeset/40315

Surfacing issue here for visibility for those who are modifying the theme using the GitHub source, as it appears it is not the most recent source code (why?). If you're inverting control of wp_enqueue_script for asynchronous loading note navigation.js has a hard dependency on jQuery currently not listed in this source.

Thanks!

ghost commented 7 years ago

Initial development for Twenty Seventeen happened on GitHub. Please do not create issues or send pull requests. Submit patches to http://core.trac.wordpress.org/ instead.

Ah. Please consider updating the README so this is clearly state there as well.