remove unused variable

[mehidi258]

Removed unused variable $logo_id from functions.php

[ntwb]

Thanks for contributing and the PR @mehidi258 :)

There's another unused variable here, can you add that to you PR please?

https://github.com/WordPress/twentytwenty/blob/master/inc/template-tags.php#L235

[mehidi258]

Thanks @ntwb I'have added another unused variable on my PR.

[carolinan]

Please remove the new title attribute that has been added.

Title attributes are bad for accessibility because it repeats the text. There already is a screen reader text there.

[mehidi258]

Thanks @carolinan :) Removed unnecessary title attr.

[ianbelanger79]

Thanks for submitting the PR. However, it is failing the travis tests due to the warnings listed below. Please fix these and resubmit.

FILE: header.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
----------------------------------------------------------------------
  97 | WARNING | [x] Array double arrow not aligned correctly;
     |         |     expected 2 space(s) between "'container'" and
     |         |     double arrow, but found 6.
     |         |     (WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned)
  98 | WARNING | [x] Array double arrow not aligned correctly;
     |         |     expected 1 space(s) between "'items_wrap'" and
     |         |     double arrow, but found 5.
     |         |     (WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned)
 107 | WARNING | [x] Expected 1 space between "'match_menu_classes'"
     |         |     and double arrow; 2 found.
     |         |     (WordPress.Arrays.MultipleStatementAlignment.LongIndexSpaceBeforeDoubleArrow)
 109 | WARNING | [x] Array double arrow not aligned correctly;
     |         |     expected 1 space(s) between "'title_li'" and
     |         |     double arrow, but found 12.
     |         |     (WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned)
 110 | WARNING | [x] Array double arrow not aligned correctly;
     |         |     expected 3 space(s) between "'walker'" and
     |         |     double arrow, but found 14.
     |         |     (WordPress.Arrays.MultipleStatementAlignment.DoubleArrowNotAligned)
----------------------------------------------------------------------

Thanks