search

WordPress / twentytwenty

Twenty Twenty is included in Core as of WordPress 5.3 🎉 To report any issues, please go here: https://core.trac.wordpress.org/newticket
Other
301 stars 140 forks source link

Selecting a Background Color preset for the Group block should automatically change the text color #964

Closed YanCol closed 5 years ago

YanCol commented 5 years ago

Some blocks don't have text color settings (Quote, List, Table...). If the user adds one of these blocks inside a group and selects the Primary, Accent or Secondary Color as the Background Color, the text is unreadable (and not AA compliant). It also doesn't work with custom colors.

Like Twenty Nineteen, Twenty Twenty should at least define the text color in accordance with the background color presets.

Group without Background Color Group with Primary Background Color
no-background background
pattonwebz commented 5 years ago

Hey @yannickiki I merged some code which I think resolves this as best as we can right now. If other issues are noted could we report them via trac so we can work on them after release. Thank you!