WordPress / twentytwenty

Twenty Twenty is included in Core as of WordPress 5.3 🎉 To report any issues, please go here: https://core.trac.wordpress.org/newticket
Other
300 stars 138 forks source link

Fixes for the Columns block #967

Closed andersnoren closed 4 years ago

andersnoren commented 4 years ago

This PR contains fixes for the Columns block issues created by @yannickiki earlier today.

Fixes #963 and #961 by removing the paragraph-only padding used for the first and last columns in full-width columns blocks previously, and replaces it with a horizontal padding on the block as a whole. This made it possible to reduce the amount of CSS quite a bit, since it removed the need for different solutions for different breakpoints.

Before After
image image

Fixes #960 by adjusting the spacing between stacked Columns blocks between 782px and 999px. Also tweaked the margin on desktop, to make the horizontal margin between stacked columns blocks 32px (same as the gutter) on all screen sizes.

Before After
image image
carolinan commented 4 years ago

@yannickiki Do you have time to test this? :)