WordPress / twentytwentyfive

149 stars 102 forks source link

Right aligned blog with vertical heading: Make sure there is only one H1 heading #279

Closed carolinan closed 1 month ago

carolinan commented 1 month ago

Description

On the right aligned blog with vertical heading, the site title is set to the H1 heading level. The site title should not be used as the main H1 of the page, since it describes the site, not the content on the current page. On some of the templates, there are currently two H1 headings.

Tasks:

carolinan commented 1 month ago

Actually, the "header" in these templates need to be added as a template part, otherwise, the navigation will not be the same for the template set. The user may accidentally add one menu for the home and a different one for the single.

KevinTaron commented 1 month ago

Actually, the "header" in these templates need to be added as a template part, otherwise, the navigation will not be the same for the template set. The user may accidentally add one menu for the home and a different one for the single.

Is that even possible? In the "header"-templatepart we have a row instead of a stack and the Navigation is not Overlay-Menu: "Always"

carolinan commented 1 month ago

It needs to be a new template part.

KevinTaron commented 1 month ago

added a pull request for this #285