WordPress / twentytwentyfive

152 stars 103 forks source link

Task: Test responsiveness #311

Closed carolinan closed 2 weeks ago

carolinan commented 1 month ago

Description

Please hold off this testing until the "blocked" label has been removed, once the patterns have been added to the theme.

Step-by-step reproduction instructions You can test the responsiveness on your devices on your own local network, a live hosted WordPress site, or using this Playground link for the theme

Please test on a real device if possible, since the experience in for example the browser developer tools may differ.

Create new pages and posts. Add both smaller patterns, full width patterns, and the different templates. Try the menus.

Templates are changed by going to Appearance > Editor > Templates, selecting the template type, and changing the pattern in the Design panel in the settings sidebar.

Test on portrait and landscape modes.

Look for and report problems that are obvious issues.

klf6890 commented 1 month ago

I'm working on this for Contributor Day

klf6890 commented 1 month ago

I'm not sure if this is an intentional design choice but in the pattern Heading and Paragraph with Image on Right, at the mobile level, the padding on the left and right are not equal. Again, unsure if a design choice as the section is indented on larger sizes, but it does look odd when combined with other patterns which mostly seem to adhere to a standard padding on the left and right. Screenshot attached from an iPhone 13 with a browser width of 390px IMG_4257

klf6890 commented 1 month ago

All patterns were testing on an iPhone 13, screen size 390px wide, I'm flagging these issues and including screenshots as they really just need to be reviewed. Some could be design choices, but if it looked odd to me on the mobile level, it's included here.

carolinan commented 1 month ago

@klf6890 Thank you for the testing and reports.

kimclowa8c commented 1 month ago

I'm finding mobile a pretty solid experience! I have found two items which are very small, but not sure if they're worth mentioning:

  1. If WooCommerce is installed, the image in the default store page doesn't align with the content block. 371103510-0b6ced12-b0ec-46c3-9d23-b35922220ccc

  2. The VideoBlock is displaying with a blank image on mobile: IMG_6791

Here's how it looks on desktop as a comparison (and yes, look how cute my dog was as a pup!)

Screenshot 2024-09-26 at 13 01 05
carolinan commented 2 weeks ago

@klf6890 @kimclowa8c What are your wordpress.org usernames? I want to make sure you get props for testing.

carolinan commented 2 weeks ago

I tested 2025.wordpress.net on Pixel 8 pro, Chrome, and I did not see any obvious layout issues: As I have already mentioned I struggle with the small default font size for the content, and it is even smaller in the cite of the testimonial patterns.

In the "Tell your story" "Hero with full width image" pattern, the button is cut off, half of it is below the fold which is not great.

dugyen commented 2 weeks ago

Testing responsiveness for our awaited Twenty Twenty-Five Theme Description Test responsiveness of WordPress 6.7 Twenty Twenty-Five Theme

Environment

Steps

  1. Create new pages and posts.
  2. Add both smaller patterns, full-width patterns, and the different templates.
  3. Try the menus.
  4. Templates are changed by going to Appearance > Editor > Templates, selecting the template type, and changing the pattern in the Design panel in the settings sidebar.
  5. Test on portrait and landscape modes.
  6. Look for and report problems that are obvious issues.

    Expected Results

  7. ✅ Twenty Twenty Theme is responsive with browsers, mobile, desktop and tablets

    Actual Results

  8. ✅ Twenty Twenty Theme is Responsive with WordPress 6.7-beta 3

Supplemental Artifacts

Image https://vioo.cc/v/5ljTe

carolinan commented 2 weeks ago

We triaged this issue on Monday and agreed to close this as completed.

kimclowa8c commented 2 weeks ago

What are your wordpress.org usernames? I want to make sure you get props for testing.

Thank you @carolinan. Mine is kimclow

klf6890 commented 2 weeks ago

What are your wordpress.org usernames? I want to make sure you get props for testing.

Oh, thanks @carolinan! Mine is KristinCodesWP