search

WordPress / twentytwentyfive

119 stars 83 forks source link

Use standard page category slug for pages #398

Open richtabor opened 1 week ago

richtabor commented 1 week ago

Why use a bespoke category for TT5's pages? TT4 just used page — source. Seems like unnecessary complexity that also puts TT5 at risk if core does more for page categories in the future.

CleanShot 2024-09-24 at 16 25 35

carolinan commented 1 week ago

Page is not an existing block pattern category.

If you look at WordPress trunk instead, TT4 does not use page anymore: https://core.trac.wordpress.org/browser/trunk/src/wp-content/themes/twentytwentyfour/functions.php#L194

Here is the Trac ticket.

richtabor commented 1 week ago

Why did that change? There's no reason to be unique? Does it matter if the label is changed by a plugin to "Pages" or else? Seems an over-optizimation.

It just makes things more complicated for future iteration on "page" patterns, as they're not categorized consistently. :/

If core adds a page category, these themes will be left out of the loop.

carolinan commented 1 week ago

If core adds a page category, TT5 and the older bundled themes will not be able to support it fully, because they have a minimum required WordPress version which matches the version the theme was first released with.

carolinan commented 1 week ago

Is there an open Gutenberg issue or core ticket to add the page category and what would updating the themes involve?

richtabor commented 1 week ago

If core adds a page category, TT5 and the older bundled themes will not be able to support it fully, because they have a minimum required WordPress version which matches the version the theme was first released with.

It's unfortunate. I'd expect that any theme that supports patterns should be able to. Just like how "My Patterns" was added.