search

WordPress / twentytwentyfive

120 stars 84 forks source link

A header may be missing for the news blog alternative templates #498

Open carolinan opened 4 days ago

carolinan commented 4 days ago

In Figma some of the news blog templates have a vertical menu, not horizontal. This design and this header is not part of the theme. If this is correct, can the Figma files please be updated so that more time is not spent on it?

I don't mind how the vertical menu looks. But I am concerned that if it is implemented, it will only work as long as the user keeps the menu short. It is not possible for the theme or the block to limit the number of menu items.

News blog with featured posts grid Image

News blog with sidebar Image

Left-aligned content Image

carolinan commented 4 days ago

OK, I found it: header-large-title.php. It does not seem to be used anywhere in the theme. Perhaps someone can remind me if this was a conscious decision. @beafialho @juanfra.

beafialho commented 4 days ago

This header should be a part of the theme, since it gives users an opinionated header layout option to use where they see fit.

carolinan commented 4 days ago

OK, but it is not supposed to be used in these templates by default? If that's the case we don't need to make any other changes than adding it to theme.json.

beafialho commented 3 days ago

It was intended to be used in these 3 templates by default. I can't exactly recall why it wasn't added in the first place.

Image

carolinan commented 1 day ago

Let's leave this until last, if there is time left we can look at it then.