search

WordPress / twentytwentyfive

120 stars 84 forks source link

Fix/banner book desc heading #510

Closed troychaplin closed 22 hours ago

troychaplin commented 1 day ago

Description

Pattern uses an H3, creates incorrect heading level a11y error

Testing Instructions

  1. Add "Banner with book description" pattern to a page
  2. Check H2 is used
github-actions[bot] commented 1 day ago

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: troychaplin <areziaal@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions[bot] commented 1 day ago

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR. ⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.