search

WordPress / twentytwentythree

Twenty Twenty-Three, the default WordPress theme sporting many styles that will launch with WordPress 6.1.
123 stars 65 forks source link

Fluid typography and Mobile Navigation button do not work on WP 6.1 #214

Closed mayuge3 closed 2 years ago

mayuge3 commented 2 years ago
  1. Theme.json fluid is true, but output font size presets are not fluid values.

n1625

  1. Nothing happens when I click the mobile navigation button (the menu doesn't pop up).

n1629

Tested with: WP 6.1 (latest nightly via Beta Tester plugin), instawp install TT3 included in WP 6.1 nightly. Chrome 106.0.5249.62 Windows 10

Sorry if here is not the right place to report.

ramonjd commented 2 years ago

I suspect this will be fixed in https://github.com/WordPress/wordpress-develop/pull/3362

desrosj commented 2 years ago

Hi @mayuge3! Thanks for your recent bug reports!

If you don't mind, could you create a wordpress.org account (if you haven't already) and link it to your GitHub one following the instructions here: Associating GitHub accounts with WordPress.org profiles

This will help ensure that you receive proper attribution (which is based on wp.org usernames) when your contributions (which bug reports are absolutely considered) when new versions of WordPress are released.

mayuge3 commented 2 years ago

Thank you @desrosj ! I made an account @mayuge on WordPress.org and linked my GitHub.

mikachan commented 2 years ago

Closing as will be fixed by https://github.com/WordPress/wordpress-develop/pull/3362.

mayuge3 commented 2 years ago

@mikachan Fluid typography now works on the latest nightly WP 6.1-beta2-54363, thank you!

However, the mobile navigation button still does not work without gutenberg plugin. Should I wait for more updates or create a new issue?

mikachan commented 2 years ago

Thank you for clarifying this! It could be that this is being fixed by another update, but it sounds like https://github.com/WordPress/wordpress-develop/pull/3362 didn't cover it. It may be worth opening a new issue in the Gutenberg repo.

@ramonjd, do you know if the issue with the responsive navigation button not working without Gutenberg may be fixed in an existing PR? (I'll also see if I can find a related issue/PR.)

Edit: I've opened an issue here: https://github.com/WordPress/gutenberg/issues/44638

mikachan commented 2 years ago

Following up on the above: the navigation overlay button should be fixed in 6.1 Beta 3 with https://github.com/WordPress/wordpress-develop/pull/3395 🎉

mayuge3 commented 2 years ago

The navigation overlay button now works in 6.1 beta3. Thank you!