search

WordPress / twentytwentytwo

Twenty Twenty-Two, the default WordPress theme that will launch with WordPress 5.9.
406 stars 91 forks source link

Replacing default header with header-large-dark adds horizontal padding to it #299

Closed zaguiini closed 2 years ago

zaguiini commented 2 years ago

Describe the bug

When starting with a fresh site and replacing the default header template part with Header -- Dark, unexpected horizontal padding is added to the header block itself.

To Reproduce Steps to reproduce the behavior:

  1. Create a new site with TT2;
  2. Highlight the Header block;
  3. Click Replace on the book settings popover;
  4. Select Header -- Dark.

Verify that some horizontal padding has been added to the header itself.

Expected behavior

The header should span across the page, with no outer padding.

Screenshots

Editor Live site
image image

Additional context

This doesn't happen when:

It only happens within the default Index template.

kjellr commented 2 years ago

@zaguiini I believe this should be all set as of #291. Here's a GIF of what I see when testing against the latest in this repository:

headers

zaguiini commented 2 years ago

@zaguiini I believe this should be all set as of #291. Here's a GIF of what I see when testing against the latest in this repository:

headers

Awesome. Let me try again running trunk this time.

zaguiini commented 2 years ago

The issue is indeed fixed. Thanks, @kjellr!