Use custom unit spacers in templates and patterns

kjellr commented 2 years ago

Fixes #272.

⚠️ This PR is reliant on https://github.com/WordPress/gutenberg/pull/36186 being backported for the 5.9 release.

When this PR is active, everything should look the same on the front-end and in the editor. Here's what's changed under the hood:

The space between posts is now uses custom units, and maps directly to the theme's var(--wp--custom--spacing--large) variable. Before, it was a static pixel number that approximated that value.
The dark header templates and patterns now include spacers to adjust their bottom margin, instead of hardcoding a margin value. That means folks can edit that value via the UI now.

Screenshot

kjellr commented 2 years ago

As per the notes in https://github.com/WordPress/gutenberg/pull/36186#issuecomment-1008538808, dynamic spacer units won't make it into the initial 5.9 release. We should likely port this over to Trac post-release so we can follow up when they become available in a minor release.

kjellr commented 2 years ago

I'm going to close this PR for now, since it's out of date. But I'll we should follow up on this again for the next point release. 👍