WordPress / twentytwentytwo

Twenty Twenty-Two, the default WordPress theme that will launch with WordPress 5.9.
405 stars 92 forks source link

Try a static spacer underneath the header #327

Closed kjellr closed 2 years ago

kjellr commented 2 years ago

Alternative to #325 and #319. Closes #272.

This PR adds a static spacer block under the header to replace the unsupported margin value that was there previously. Ideally, this should be a dynamic value, but this is the best we can do for the moment since that's not landing in 5.9.

Using a static value produces more space than intended on mobile, but overall I think the usability enhancement makes it worthwhile for the initial release. This also makes for a more efficient transition to #325, once dynamic spacer units will be supported in a future minor release. I (somewhat regretfully) think this is the best path forward for the moment.


Editor:

Screen Shot 2022-01-10 at 11 36 08 AM

Frontend:

(Front-end desktop views are identical to trunk.)

Before After
Screen Shot 2022-01-10 at 11 33 34 AM Screen Shot 2022-01-10 at 11 33 45 AM
Before After
Screen Shot 2022-01-10 at 11 33 20 AM Screen Shot 2022-01-10 at 11 29 13 AM