search

WordPress / twentytwentytwo

Twenty Twenty-Two, the default WordPress theme that will launch with WordPress 5.9.
405 stars 92 forks source link

Should all header patterns have the core/site-logo block? #329

Closed richtabor closed 2 years ago

richtabor commented 2 years ago

Is your feature request related to a problem? Please describe. It's difficult to add a Site Logo block to an existing pattern. It requires adding a Row block (Group) then adding the site-title and additional site-logo block to it, the adjusting it to display beside the existing navigation. It's not an easy task — but removing a site-logo block is (if the user chooses not to have the logo).

Describe the solution you'd like Consider updating the header patterns to consistently include site-logo blocks.

Screenshot

CleanShot 2022-01-10 at 19 43 09@2x

*I added the TT2 label to tell which were TT2 and which were not for myself :)

kjellr commented 2 years ago

Thanks for the issue. I don't think all patterns should include one — some folks will want a logo and other won't. There is a site logo in the default header, so at least there's that.

In retrospect, we could've probably included a handful more patterns that do feature a site logo, but we aren't going to add more in at this point in RC. It's possible we can add some later, but I think once the pattern directory hosts some header patterns we probably won't need to.

Regarding the usability issues around adding one in to a row block — do you think there's a Gutenberg issue worth filling in there somewhere?

In any case, I'm going to close this for now, but we can keep discussing if anyone has further thoughts!