search

WordPress / twentytwentytwo

Twenty Twenty-Two, the default WordPress theme that will launch with WordPress 5.9.
406 stars 91 forks source link

Also allow stacking of negative margins in cover #339

Closed erikjoling closed 2 years ago

erikjoling commented 2 years ago

Description

A fully aligned block inside a fully aligned cover-block needs to have double negative margins, because it has double positive paddings. If this makes sense ^_^'

Just like the group block.

Testing Instructions

  1. Add a fully aligned group-block inside a fully aligned cover block.
  2. See double horizontal padding.
kjellr commented 2 years ago

Thanks, @erikjoling! This looks good:

Before After
Screen Shot 2022-01-20 at 12 02 50 PM Screen Shot 2022-01-20 at 12 03 13 PM

@jffng and I aren't making any more bugfix commits in advance of the 5.9 code freeze on Monday, so we'll save this one and can push it in shortly after release.

Thank you!

erikjoling commented 2 years ago

No problem at all. Thank you, also for the great theme :)

jffng commented 2 years ago

Migrated to a PR in core, thanks again @erikjoling ! https://github.com/WordPress/wordpress-develop/pull/2223