search

WordPress / wordcamp.org

WordCamps are casual, locally-organized conferences covering everything related to WordPress.
https://wordcamp.org
132 stars 74 forks source link

WordCamp.org: cancelled camps visible with URL #602

Open ghost opened 6 years ago

ghost commented 6 years ago

Imported from https://meta.trac.wordpress.org/ticket/3740 Created by @timiwahalahti:

For example, WC Rhode Island (post ID 3057593) is marked as "Cancelled", but still visible when accessing the URL https://central.wordcamp.org/wordcamps/wordcamp-ri-usa/. It shouldn't since it is canceled, right?

ghost commented 6 years ago

Comment by slackbot:

This ticket was mentioned in Slack in #meta-wordcamp by sippis. View the logs.

ghost commented 6 years ago

Comment by @iandunn:

ghost commented 6 years ago

Comment by @timiwahalahti:

Today in WC bug scrub Ian said (note ro me for doing patch)

Probably just need to update that old theme template to use the new WordCamp_Loader::get_public_post_statuses() (i'm not sure if i'm remembering the class/function name exactly right, but it's something similar to that)

ghost commented 5 years ago

Comment by @timiwahalahti:

This was a somewhat larger issue than I expected. Looks like you can access to every WordCamp info page on central.wordcamp.org regardless of its status.

Does every old WordCamp have a status? In WME WC's didn't have any status so also valid old camps did start giving a 404. A quick look on the production version WC list gives a feeling that every camp has a status, but this needs to be double-checked before applying the patch to production.

Patch extends existing query_public_statuses_on_archives function in wcpt plugin to limit singular WordCamp views on central.wordcamp.org/wordcamps/* to view only camps with public status. I extended the existing function to check also singular views, because it made more sense than adding a new check to new function.

ghost commented 5 years ago

Comment by @timiwahalahti:

ghost commented 5 years ago

Comment by slackbot:

This ticket was mentioned in Slack in #meta-wordcamp by sippis. View the logs.

ghost commented 5 years ago

Comment by @timiwahalahti:

ghost commented 5 years ago

Comment by @timiwahalahti:

Updated diff:

ghost commented 5 years ago

Comment by @timiwahalahti:

ghost commented 5 years ago

Comment by slackbot:

This ticket was mentioned in Slack in #meta-wordcamp by iandunn. View the logs.