WordPress / wordpress-importer

The WordPress Importer
https://wordpress.org/plugins/wordpress-importer/
GNU General Public License v2.0
78 stars 76 forks source link

WP Version required bump seems unnecessary #135

Open smileBeda opened 1 year ago

smileBeda commented 1 year ago

Might I ask what the reasoning behind the bump of minimally required WP version is?

With WP 5.2 being the new minimum supported WP version, the polyfill for the map_deep() function is no longer needed. Similarly, the bowing out for the term meta import (on WP < 4.4) is also no longer needed.

Neither of both are a real cause.

The mentioned reasons on the release post thus cannot be the justification of dropping all installs below 5.2, and specially since this is an "inbuilt" plugin (linked from the tools area), would it be possible to revert this in a future release, so it can stay around for older installs too?

dd32 commented 1 year ago

See #95 for the discussion around it, notably, it's about the maintenance burden and ongoing maintenance of the plugin, rather than intentionally leaving older installs "out in the cold". Older WordPress versions could still use the older versions of the plugin, although we don't offer an easy way for those to be installed at present (or ever in those older versions).

Perhaps the question should be asked here, is what's the use-case needed for using the latest version of the importer on an older version of WordPress? Or is it just the inability to install the older versions of the plugin easily?

Previously the minimum was WordPress 3.7, if we were to change anything here, I would suggest WordPress 4.0+ based on the upcoming Security Support policy change.

smileBeda commented 1 year ago

The use case is, that an older install of WP will fail to install that importer from the tools menu. Of course, they can manually download an older version, but as far I am concerned not many users to even know they can download older versions, and those who know, might refrain out of fear to be running outdated software equals unsafe software.

There are approx 38'675'000 websites still on pre 5.2 out of the alleged 455 millions running WP. It's not nothing.


if we were to change anything here, I would suggest WordPress 4.0+ based on the upcoming Security Support policy change.

I think that would be the "conscious" thing to do, specially since this is a "integrated" plugin, directly accessible in the WP Tools menu and not "obviously" a plugin to many users (they think it is just a feature to enable) However, the min-required has to be 4.4 at this point unless you'd want to bring back the removed code as well.

Note that the big chunk of those 38'675'000 websites is actually on WP 4.9, so it would at least catch a big part of them.

Thanks!

dd32 commented 1 year ago

The use case is, that an older install of WP will fail to install that importer from the tools menu.

Oddly enough, this isn't actually true - A WordPress 4.4 site can install through that tools menu, it does display a "This plugin hasn't been marked compatible with your version of WordPress" though.

I wasn't able to find it, but I believe the code which adds that restriction is in WordPress 4.9 or 5.0. Still lower than the minimum 5.2 here though.

Edit: Confirmed that 4.9 is fine, and in 5.1 the Details popup says it's not compatible and cannot install, but the "Install importer" link on the importer page works fine to install it anyway.

tl;dr: Older installs are not actually prevented from installing the plugin or using it, but pre-4.4 sites probably are broken, but I still question the need to support it.

There are approx 38'675'000 websites still on pre 5.2 out of the alleged 455 millions running WP. It's not nothing.

It's not nothing, and I'm not going to argue the number of sites, but the question should be asked if any such old installations of WordPress would be attempting to install a new importer plugin, and whether we would want to support them doing so. My thought is that no, we don't. We want them to update their WordPress installation instead.

These older versions of WordPress are no longer officially supported, even the versions of WordPress Core that we perform security back-porting for (3.7/4.0) are not officially supported - only the latest stable branch is.

jrfnl commented 1 year ago

Just two more pennies for perspective: AFAIK the importer plugin is typically used when setting up a new (WP) site, i.e to import posts which were previously in another website, either WP or based on another framework, and convert them to the (current) WP format. Any new site should use the latest version of WP.

I understand there will be other usecases as well (merging multiple pre-existing blogs), but I would imagine that those are less frequent and even in that case, it is not that strange to expect the user to use a (more) recent version of WP.

Let's not forget WP 5.2 came out in 2019, so it's already three years old.