WordPress / wordpress-importer

The WordPress Importer
https://wordpress.org/plugins/wordpress-importer/
GNU General Public License v2.0
78 stars 76 forks source link

Update tested up to label and test matrix #155

Closed ouikhuan closed 8 months ago

ouikhuan commented 8 months ago

How to test:

ouikhuan commented 8 months ago

I realized that even after removing PHP 5.6 from the test.yml matrix it's still showing up as expected check. Should we do this update in another PR?

jrfnl commented 8 months ago

I realized that even after removing PHP 5.6 from the test.yml matrix it's still showing up as expected check. Should we do this update in another PR?

That is unrelated to your PR. The required builds are defined in the protected branch settings and the way the branch protection is set up for this repo it will now literally block every single PR from being merged.

I just checked and while I can commit, I cannot change the branch protection, so you now have the not very enviable task to figure out who on this earth has admin rights for this repo and can set the branch protection to something a little more sane.

In my opinion, the following changes need to be made:

Aside from the above, there are a number of PRs open (and rotting for over a year) which make various improvements to the GH Actions workflows. Those PRs should be merged with priority to keep things running smoothly and never be left to rot.

I would merge them myself now, except due to the long time between when I pulled them and now and having to rebase them due to the branch protection settings, I can't merge them anymore with the failing PHP 5.6 build.

In my opinion, we should also add a dependabot config to automatically update action runners as those are going out of date fast now too.

All in all, it comes down to nobody taking ownership of this repo and that being problematic when changes need to be made/merged/released.

ouikhuan commented 8 months ago

Thanks for the suggestion @jrfnl , please let me know if I can help on those pending PRs from you. @vishnugopal, what do you think based on the suggestion above? Do we have permission to modify the settings?