WordPress / wordpress-playground

Run WordPress in the browser via WebAssembly PHP
https://w.org/playground/
GNU General Public License v2.0
1.65k stars 263 forks source link

Rewrite clone examples to use HTTPS instead of SSH #1963

Closed bgrgicak closed 3 weeks ago

bgrgicak commented 3 weeks ago

Let's use https instead of ssh in our cloning instructions because some people might not have GitHub ssh configured on their machines, while https works for everyone.

A user reported that they have issues with cloning Playground . I'm not sure what the root cause of the issue is, but it prompted me to rewrite the cloning instructions to remove friction from the setup process.

Testing Instructions (or ideally a Blueprint)

adamziel commented 3 weeks ago

What are the downsides of defaulting to HTTPS?

bgrgicak commented 3 weeks ago

What are the downsides of defaulting to HTTPS?

TL;DR; From reading GitHub docs and this article .

If our goal is to help people get started I would choose HTTPS, because it has less friction. SSH takes more effort, but long-term is a better approach because of speed and security.

adamziel commented 3 weeks ago

Sounds good, let's default to HTTP, then.

Performance-wise, they say it might matter with large repos or slow connections – let's stay on the lookout for any unsettling signals from the contributors.

Performance – Generally, there’s not a significant difference in performance between HTTPS and SSH for cloning Git repositories. However, in some cases, SSH might provide faster data transfer rates particularly when working with large repositories or when the internet connection is slow.