WordPress / wordpress-playground

Run WordPress in the browser via WebAssembly PHP
https://w.org/playground/
GNU General Public License v2.0
1.65k stars 263 forks source link

Temporary playground sidebar when there is no Playground #1973

Open ajotka opened 3 weeks ago

ajotka commented 3 weeks ago

When there is no temporary playground [1], after entering settings [2] and blueprint gallery [3], and then clicking temporary playground [4], nothing happens in sidebar. The sidebar for temporary playground should open. (If you click it straight away, without going through the blueprint gallery, it works).

  1. Image
  2. Image
  3. Image
  4. Image
bph commented 3 weeks ago

The screen is also briefly, very briefly visible when loading a Playground instance from a link.

Here is a short video. Don't blink, though. Following a link from the Gutenberg Examples page.

https://github.com/user-attachments/assets/f79fe52c-11f5-45bb-a57e-7382de481781

bgrgicak commented 3 weeks ago

@ajotka how are you able to recreate this? The Playground website should always have a temporary site, and if there isn't one it's definetly a bug.

The demo @bph shared looks like a React-related bug where it briefly renders the No Playground screen while Playground is being created.

ajotka commented 3 weeks ago

@bgrgicak looks like it was related to https://github.com/WordPress/wordpress-playground/pull/1908#discussion_r1824682358 and now is fixed :) I tested in local environment, and now it's working.

Should we create a separate issue for reported screen from @bph and close this one?

brandonpayton commented 3 weeks ago

The screen is also briefly, very briefly visible when loading a Playground instance from a link.

Hi @bph, are you referring to this part of the screen recording? Image

bgrgicak commented 3 weeks ago

@brandonpayton I think it was this.

Image

bgrgicak commented 3 weeks ago

Should we create a separate issue for reported screen from @bph and close this one?

Sounds good @ajotka! We could also just rename this one if it's something we can address immediately, so that we don't lose the discussion.