Fix path of PR preview URL in production - Githubissues

WordPress / wordpress-playground

Run WordPress in the browser via WebAssembly PHP

https://w.org/playground/

GNU General Public License v2.0

1.65k stars 261 forks source link

Fix path of PR preview URL in production #2014

Closed brandonpayton closed 12 hours ago

brandonpayton commented 13 hours ago

Motivation for the change, related issues

This fixes a problem with the PR preview URLs created by the PR preview modals in production.

Before this fix, a preview URL created by the modal in production looks like

https://playground.wordpress.net/null./?core-pr=7757#...

cc @ajotka

Implementation details

This PR uses the current app location path as a basis for the PR preview URL.

Testing Instructions (or ideally a Blueprint)

CI
Test PR preview in web app with npm run dev
Run npm run build, run php -S localhost:8888 -t dist/packages/playground/wasm-wordpress-net, and manually test PR preview for WP PRs

brandonpayton commented 12 hours ago

note: There are e2e test failures, but they seem to be the same as we were already seeing on trunk.

Let's merge this.