WordPress / wordpress.org

WordPress.org Meta, Git-ified. Synced from git://meta.git.wordpress.org/ This repository is just a mirror of the WordPress Meta subversion repository. Please include a link to a pre-existing ticket on https://meta.trac.wordpress.org/ with every pull request.
https://meta.trac.wordpress.org/
109 stars 140 forks source link

Plugins: Add "Community" and "Commercial" descriptions to search archives #308

Closed ndiego closed 3 months ago

ndiego commented 4 months ago

Since the most recent refresh, there has been some discussion around the "Community" and "Commercial" categories. While these categories have been in place for quite some time, what stood out to me is that while there are descriptions on the category archives, there is no description on the search archive when you filter by either term.

I think adding the descriptions to the search archives when either term is selected would be helpful.

Category archives Search archive + selecting a term Proposed (needs design help)
image image image
ndiego commented 4 months ago

My proposed mockup needs some design help, but what do you think of this approach @WordPress/meta-design?

jasmussen commented 4 months ago

Could it be Community results for "blocks"? It's notably this double heading that looks awkward:

Screenshot 2024-05-07 at 16 19 45

The gray help text can sit under the heading per usual, if that's helpful.

ndiego commented 4 months ago

Could it be Community results for "blocks"?

Yeah I think that could work nicely.

It's notably this double heading that looks awkward: The gray help text can sit under the heading per usual, if that's helpful.

Agreed on both.

fcoveram commented 4 months ago

I don't see the reason for adding the Search results for: "blocks" part. Regardless of supporting the idea, and previously sharing a mockup for it, it currently does not exist in the other sections.

With that in mind, and in sync with #309, I would remove that text, place all search actions in one row, and include the category description.

Here is a mockup gathering the three changes mentioned.

Mockup of Plugins search results

ndiego commented 4 months ago

I don't see the reason for adding the Search results for: "blocks" part.

That's the title (<h1>) on the page. It probably needs to be there for SEO/accessibility, but I am not an expert.

fcoveram commented 4 months ago

So in that vein, do we need to update the all search results pages? If so, I then would like to go back to the idea shared previously that adds a sentence above the results grid.

ryelle commented 4 months ago

That's the title (<h1>) on the page. It probably needs to be there for SEO/accessibility, but I am not an expert.

That's correct, but technically we can hide it with the screen-reader-text class as long as it's clear to sighted users what the current page context is. For example, on patterns we have this on all archives, but we can hide it because the breadcrumbs give context + the item is selected in the menu.

Archive Search results
Screenshot 2024-05-08 at 10 28 44 AM Screenshot 2024-05-08 at 10 34 00 AM
ndiego commented 4 months ago

That's correct, but technically we can hide it with the screen-reader-text class as long as it's clear to sighted users what the current page context is. For example, on patterns we have this on all archives, but we can hide it because the breadcrumbs give context + the item is selected in the menu.

Based on this, I like your mockup @fcoveram. 👇

Mockup of Plugins search results

@StevenDufresne thoughts on moving forward with this iteration? Note this mockup does include the proposed changes in #309

ryelle commented 4 months ago

The proper heading for a search results page should be "Search results" or "Search results for [term]", though. The production site is doing this correctly, now. Otherwise this has the same h1 as the main "Community" archive. And there can only be one h1 here, so the invisible heading doesn't apply, as there's already one visible h1.

Maybe the headings can be combined to be "Community plugins: Search results for [term]" with the description under it?

ndiego commented 4 months ago

Could "Community plugins" be an h2 like the headings (that look the same) on the Homepage?

ryelle commented 4 months ago

I suppose (technically nothing wrong with it), but I feel like you're loosing half the context either way. Instead of only saying search results like production does now, it'll only (appear to) say "community plugins" — only screen reader users will get the benefit of full context.

IMO it works on Patterns because there is no heading, so you look to the filters & breadcrumbs. Here, there is a heading, but it's not the full story, so it feels just as strange as the original issue. But this isn't a strong opinion, so feel free to outvote me.

ndiego commented 4 months ago

I think "Community plugins: Search results for [term]" could work well too. No stong opinions here either

StevenDufresne commented 4 months ago

For me, this is the same conversion we are having in https://github.com/WordPress/wporg-mu-plugins/discussions/603 and it should be solved consistently across patterns/plugins/themes.

I feel like we can do category education with a tooltip (assuming we can make it accessible).

Group 1 (18)
ndiego commented 4 months ago

I feel like we can do category education with a tooltip (assuming we can make it accessible).

That's a cool idea!

StevenDufresne commented 4 months ago

@fcoveram Do you have any thoughts on this idea?

fcoveram commented 4 months ago

I like the idea. Do you have an idea for the "Learn more" link? I don't think we need it.

ndiego commented 4 months ago

I like the idea. Do you have an idea for the "Learn more" link? I don't think we need it.

The only place I can think to link to is the Make post 🤔 I am surprised there is no information (that I could find) in the WordPress.org Plugin Directory section of the Plugin Handbook.

StevenDufresne commented 4 months ago

We could exclude it from the first iteration but I think it's valuable to have a place for plugins to visit that explains the categorizations along with how to categorize their plugin in the future.

ndiego commented 3 months ago

As a first step, I would love to see something like this when "test" is searched for:

Search for all Search for community Search for commercial
image image image

This is similar to what is being done in the Patterns Directory. It doesn't solve all issues, but does provide more context to the search and should be easy to implement.

jasmussen commented 3 months ago

That feels a great start to build on, and is hopefully easy to do.

fcoveram commented 3 months ago

@ndiego's idea looks good. +1 to go with that.