WordPress / wordpress.org

WordPress.org Meta, Git-ified. Synced from git://meta.git.wordpress.org/ This repository is just a mirror of the WordPress Meta subversion repository. Please include a link to a pre-existing ticket on https://meta.trac.wordpress.org/ with every pull request.
https://meta.trac.wordpress.org/
109 stars 140 forks source link

Primary color not showing in old Rosetta site #326

Closed t-hamano closed 3 months ago

t-hamano commented 3 months ago

Related to https://meta.trac.wordpress.org/changeset/13571

The Rosetta site, including the support forums, has the new design in most locales, but in some cases where the old design is used, such as in the Japanese locale, the primary color is not displayed (See this issue for the redesign).

Old design

https://ja.wordpress.org/support/topic/%e3%83%88%e3%83%83%e3%83%97%e3%83%9a%e3%83%bc%e3%82%b8%e3%81%ab%e3%81%a4%e3%81%84%e3%81%a6/?new-theme=0

337878298-936f5702-4dc2-4429-a4b8-6cded5352035

New design

https://ja.wordpress.org/support/topic/%e3%83%88%e3%83%83%e3%83%97%e3%83%9a%e3%83%bc%e3%82%b8%e3%81%ab%e3%81%a4%e3%81%84%e3%81%a6/?new-theme=0

image

After investigating the cause, it appears that the CSS variable for the color does not exist in the old design.

https://github.com/WordPress/wordpress.org/blob/6f76c564e218c1697d139cd5a0f0ed575e4d4787/wordpress.org/public_html/wp-content/plugins/support-forums/inc/class-blocks.php#L69-L71

image

These CSS variables are probably defined in the theme.json of a theme that is only applied in the new design, so they cannot be referenced in the old design.

https://github.com/WordPress/wporg-parent-2021/blob/65fbabca9f931a18bd6f786a1c08663bd6259b3a/source/wp-content/themes/wporg-parent-2021/theme.json#L162-L165

This issue will likely be resolved automatically once all locales are migrated to the new design, but we may need to hard-code colors or provide fallback colors in CSS variables.